Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 301303003: GuestView: Move Disable Drag and Drop Out to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change_browser_plugin_guest_delegate_lifetime
Patch Set: Addressed Istiaque's comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index e1073dc4130775fc25b76c4e3c822c9b5bdb2cea..e7323ec2520a45d273a1eb86b29cc07deb5207d6 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -334,6 +334,11 @@ void WebViewGuest::Attach(WebContents* embedder_web_contents,
AddWebViewToExtensionRendererState();
}
+void WebViewGuest::DidStopLoading() {
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ DispatchEvent(new GuestViewBase::Event(webview::kEventLoadStop, args.Pass()));
+}
+
void WebViewGuest::EmbedderDestroyed() {
// TODO(fsamuel): WebRequest event listeners for <webview> should survive
// reparenting of a <webview> within a single embedder. Right now, we keep
@@ -352,6 +357,10 @@ void WebViewGuest::EmbedderDestroyed() {
view_instance_id()));
}
+bool WebViewGuest::IsDragAndDropEnabled() const {
+ return true;
+}
+
bool WebViewGuest::AddMessageToConsole(WebContents* source,
int32 level,
const base::string16& message,
@@ -448,10 +457,6 @@ void WebViewGuest::HandleKeyboardEvent(
web_contents(), event);
}
-bool WebViewGuest::IsDragAndDropEnabled() {
- return true;
-}
-
void WebViewGuest::LoadProgressChanged(content::WebContents* source,
double progress) {
scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
@@ -850,11 +855,6 @@ void WebViewGuest::DocumentLoadedInFrame(
InjectChromeVoxIfNeeded(render_view_host);
}
-void WebViewGuest::DidStopLoading(content::RenderViewHost* render_view_host) {
- scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEvent(new GuestViewBase::Event(webview::kEventLoadStop, args.Pass()));
-}
-
bool WebViewGuest::OnMessageReceived(const IPC::Message& message,
RenderFrameHost* render_frame_host) {
bool handled = true;
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698