Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 3013023: Fix regression that stopped properly restoring focus to tab contents.... (Closed)

Created:
10 years, 5 months ago by dmazzoni
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org, dhw
Visibility:
Public.

Description

Fix regression that stopped properly restoring focus to tab contents. The bug in r51262 was that native_tab_contents_container_win overrides RequestFocus, so it can't be *reliably* focused just using SetFocus. This is a simple, straightforward fix that should be merged for M6. Afterwards, I think a better solution for the dev channel would be to get rid of the hacky RequestFocus overrides and add a View::HasNativeFocus method so that FocusManager can tell when it thinks a view already has focus, but the native focus might need to be set again. Thoughts? BUG=48917 BUG=49061 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53471

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M views/focus/focus_manager.cc View 1 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
10 years, 5 months ago (2010-07-21 14:28:07 UTC) #1
sky
10 years, 5 months ago (2010-07-21 15:44:39 UTC) #2
LGTM

http://codereview.chromium.org/3013023/diff/1/2
File views/focus/focus_manager.cc (right):

http://codereview.chromium.org/3013023/diff/1/2#newcode365
views/focus/focus_manager.cc:365: if (!view->IsFocusable() &&
view->IsAccessibilityFocusable()) {
I just landed a cl that changes these method names. You'll want
IsFocusableInRootView and IsAccessbilityFocusableInRootView.

Powered by Google App Engine
This is Rietveld 408576698