Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dashboard/dashboard/pinpoint/models/job.py

Issue 3013013002: [pinpoint] Change refactor. (Closed)
Patch Set: . Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dashboard/dashboard/pinpoint/models/change/commit.py ('K') | « dashboard/dashboard/pinpoint/models/isolate_test.py ('k') | dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/pinpoint/models/job.py
diff --git a/dashboard/dashboard/pinpoint/models/job.py b/dashboard/dashboard/pinpoint/models/job.py
index 74cc46a3bd27f297e545410c1de720b5112c3ec6..dd985733cbef9b3328dd2ddeca965129de4fdb07 100644
--- a/dashboard/dashboard/pinpoint/models/job.py
+++ b/dashboard/dashboard/pinpoint/models/job.py
@@ -259,10 +259,9 @@ class _JobState(object):
try:
midpoint = change_module.Change.Midpoint(change_a, change_b)
except change_module.NonLinearError:
- midpoint = None
- if midpoint:
- logging.info('Adding Change %s.', midpoint)
- self.AddChange(midpoint, index)
+ continue
+ logging.info('Adding Change %s.', midpoint)
+ self.AddChange(midpoint, index)
elif comparison_result == _SAME:
# The same: Do nothing.
continue
« dashboard/dashboard/pinpoint/models/change/commit.py ('K') | « dashboard/dashboard/pinpoint/models/isolate_test.py ('k') | dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698