[pinpoint] Change refactor.

dashboard/dashboard/pinpoint/models/change/commit_test.py

Index: dashboard/dashboard/pinpoint/models/change/commit_test.py
diff --git a/dashboard/dashboard/pinpoint/models/change/commit_test.py b/dashboard/dashboard/pinpoint/models/change/commit_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..b7afb37d8ac469f019d947d2d1f9654634327293
--- /dev/null
+++ b/dashboard/dashboard/pinpoint/models/change/commit_test.py
@@ -0,0 +1,156 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import mock
+
+from dashboard.common import namespaced_stored_object
+from dashboard.common import testing_common
+from dashboard.pinpoint.models.change import commit
+
+
+_CHROMIUM_URL = 'https://chromium.googlesource.com/chromium/src'
+
+
+class _CommitTest(testing_common.TestCase):
+
+  def setUp(self):
+    super(_CommitTest, self).setUp()
+
+    self.SetCurrentUser('internal@chromium.org', is_admin=True)
+
+    namespaced_stored_object.Set('repositories', {
+        'chromium': {'repository_url': _CHROMIUM_URL},
+    })
+
+
+class CommitTest(_CommitTest):
+
+  def testCommit(self):
+    c = commit.Commit('chromium', 'aaa7336c821888839f759c6c0a36')
+
+    other_commit = commit.Commit(u'chromium', u'aaa7336c821888839f759c6c0a36')
+    self.assertEqual(c, other_commit)
+    self.assertEqual(str(c), 'chromium@aaa7336')
+    self.assertEqual(c.id_string, 'chromium@aaa7336c821888839f759c6c0a36')
+    self.assertEqual(c.repository, 'chromium')
+    self.assertEqual(c.git_hash, 'aaa7336c821888839f759c6c0a36')
+    self.assertEqual(c.repository_url,
+                     'https://chromium.googlesource.com/chromium/src')
+
+  @mock.patch('dashboard.services.gitiles_service.FileContents')
+  def testDeps(self, file_contents):
+    file_contents.return_value = """
+vars = {
+  'chromium_git': 'https://chromium.googlesource.com',
+}
+deps = {
+  'src/v8': Var('chromium_git') + '/v8/v8.git' + '@' + 'c092edb',
+}
+deps_os = {
+  'win': {
+    'src/third_party/cygwin':
+      Var('chromium_git') + '/chromium/deps/cygwin.git' + '@' + 'c89e446',
+  }
+}
+    """
+
+    c = commit.Commit('chromium', 'aaa7336')
+    expected = frozenset((
+        commit.Commit('cygwin', 'c89e446'),
+        commit.Commit('v8', 'c092edb'),
+    ))
+    self.assertEqual(c.Deps(), expected)
+
+  def testAsDict(self):
+    c = commit.Commit('chromium', 'aaa7336')
+    expected = {
+        'repository': 'chromium',
+        'git_hash': 'aaa7336',
+        'url': _CHROMIUM_URL + '/+/aaa7336',
+    }
+    self.assertEqual(c.AsDict(), expected)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitInfo')
+  def testFromDict(self, _):
+    c = commit.Commit.FromDict({
+        'repository': 'chromium',
+        'git_hash': 'aaa7336',
+    })
+
+    expected = commit.Commit('chromium', 'aaa7336')
+    self.assertEqual(c, expected)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitInfo')
+  def testFromDictWithRepositoryUrl(self, _):
+    c = commit.Commit.FromDict({
+        'repository': 'https://chromium.googlesource.com/chromium/src',
+        'git_hash': 'aaa7336',
+    })
+
+    expected = commit.Commit('chromium', 'aaa7336')
+    self.assertEqual(c, expected)
+
+  def testFromDictFailureFromUnknownRepo(self):
+    with self.assertRaises(KeyError):
+      commit.Commit.FromDict({
+          'repository': 'unknown repo',
+          'git_hash': 'git hash',
+      })
+
+  @mock.patch('dashboard.services.gitiles_service.CommitInfo')
+  def testFromDictFailureFromUnknownCommit(self, commit_info):
+    commit_info.side_effect = KeyError()
+
+    with self.assertRaises(KeyError):
+      commit.Commit.FromDict({
+          'repository': 'chromium',
+          'git_hash': 'unknown git hash',
+      })
+
+
+class MidpointTest(_CommitTest):
+
+  @mock.patch('dashboard.services.gitiles_service.CommitRange')
+  def testSuccess(self, commit_range):
+    commit_range.return_value = [
+        {'commit': 'babe852'},
+        {'commit': 'b57345e'},
+        {'commit': '949b36d'},
+        {'commit': '1ef4789'},
+    ]
+
+    commit_a = commit.Commit('chromium', '0e57e2b')
+    commit_b = commit.Commit('chromium', 'babe852')
+    self.assertEqual(commit.Commit.Midpoint(commit_a, commit_b),
+                     commit.Commit('chromium', '949b36d'))
+
+  def testRaisesWithSameCommit(self):
+    commit_a = commit.Commit('chromium', '0e57e2b')
+    commit_b = commit.Commit('chromium', '0e57e2b')
+    with self.assertRaises(commit.SameCommitWarning):
+      commit.Commit.Midpoint(commit_a, commit_b)
+
+  def testRaisesWithDifferingRepositories(self):
+    commit_a = commit.Commit('chromium', '0e57e2b')
+    commit_b = commit.Commit('not_chromium', 'babe852')
+    with self.assertRaises(commit.NonLinearError):
+      commit.Commit.Midpoint(commit_a, commit_b)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitRange')
+  def testRaisesWithAdjacentCommits(self, commit_range):
+    commit_range.return_value = [{'commit': 'b57345e'}]
+
+    commit_a = commit.Commit('chromium', '949b36d')
+    commit_b = commit.Commit('chromium', 'b57345e')
+    with self.assertRaises(commit.AdjacentCommitsWarning):
+      commit.Commit.Midpoint(commit_a, commit_b)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitRange')
+  def testRaisesWithEmptyRange(self, commit_range):
+    commit_range.return_value = []
+
+    commit_b = commit.Commit('chromium', 'b57345e')
+    commit_a = commit.Commit('chromium', '949b36d')
+    with self.assertRaises(commit.NonLinearError):
+      commit.Commit.Midpoint(commit_a, commit_b)