Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 3012683002: Don't try to add abstract methods to the codegen work queue to generate bodies (Closed)

Created:
3 years, 3 months ago by Emily Fortuna
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't try to add abstract methods to the codegen work queue to generate bodies BUG= R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b1dd578da725e5d223309337ad91fe540bd0e20d

Patch Set 1 #

Patch Set 2 : reran status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -226 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 9 chunks +11 lines, -14 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 4 chunks +10 lines, -4 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 14 chunks +62 lines, -56 lines 0 comments Download
M tests/language/language_dart2js.status View 1 38 chunks +94 lines, -137 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 8 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Emily Fortuna
See corresponding element code at lib/src/js_backend/element_strategy.dart:135
3 years, 3 months ago (2017-09-01 01:14:00 UTC) #2
Johnni Winther
lgtm
3 years, 3 months ago (2017-09-01 09:08:05 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-09-01 15:38:10 UTC) #6
Emily Fortuna
3 years, 3 months ago (2017-09-01 17:21:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b1dd578da725e5d223309337ad91fe540bd0e20d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698