Mark unsafe token access in AstBuilder

Mark unsafe token access in AstBuilder

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/2ee7750f8a8a51914a5b29848ffb257be4a81859

[Brian Wilkerson, 2017-08-31 15:56:59]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com

[Brian Wilkerson, 2017-08-31 15:56:59]

I believe that this captures all of the places where the parser needs to be
changed to pass in tokens explicitly (in order to support recovery).

[danrubel, 2017-08-31 17:27:50]

LGTM

https://codereview.chromium.org/3012663002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3012663002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1065: // TODO(brianwilkerson) Should
this be using ensureSemicolon?
Just FYI... I'm working on removing this code because it belongs in the parser.

[Brian Wilkerson, 2017-08-31 17:29:37]

https://codereview.chromium.org/3012663002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3012663002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1065: // TODO(brianwilkerson) Should
this be using ensureSemicolon?
Agreed.

[Brian Wilkerson, 2017-08-31 17:30:01]

Description was changed from

==========
Mark unsafe token access in AstBuilder
==========

to

==========
Mark unsafe token access in AstBuilder

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2ee7750f8a8a51914a5b29848ffb257be4a81859
==========

[Brian Wilkerson, 2017-08-31 17:30:02]

Committed patchset #1 (id:1) manually as
2ee7750f8a8a51914a5b29848ffb257be4a81859 (presubmit successful).