Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3012513002: Fix usage of csinc arm64 instruction in stubs (the 2nd operand is incremented). (Closed)

Created:
3 years, 3 months ago by regis
Modified:
3 years, 3 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix usage of csinc arm64 instruction in stubs (the 2nd operand is incremented). Committed: https://github.com/dart-lang/sdk/commit/af0552eac5d5f3d982962045f277d535a4f745c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/stub_code_arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
TBR This should turn the vm-precomp bots green.
3 years, 3 months ago (2017-08-29 18:06:34 UTC) #2
regis
Committed patchset #1 (id:1) manually as af0552eac5d5f3d982962045f277d535a4f745c9 (presubmit successful).
3 years, 3 months ago (2017-08-29 18:06:54 UTC) #4
zra
3 years, 3 months ago (2017-08-29 18:12:23 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698