Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 3012433002: Fix lib_2/async/future_test.dart multitest. (Closed)

Created:
3 years, 3 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, bkonyi
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix lib_2/async/future_test.dart multitest. It was broken by migration in 42d354c91dcd69fd468134fc9a21275f4628b7a6. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/ab83ea939f6be49b30c0d7b0f0a37e07c21d6230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/lib_2/async/future_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
PTAL
3 years, 3 months ago (2017-08-28 11:18:11 UTC) #2
floitsch
LGTM.
3 years, 3 months ago (2017-08-28 11:18:58 UTC) #3
Vyacheslav Egorov (Google)
3 years, 3 months ago (2017-08-28 11:34:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab83ea939f6be49b30c0d7b0f0a37e07c21d6230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698