Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 301243015: Refactor ThreadableLoaderOptions for readability (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 bool success = it->value->asString(&value); 744 bool success = it->value->asString(&value);
745 if (!success) { 745 if (!success) {
746 *errorString = "Request header \"" + it->key + "\" value is not a string"; 746 *errorString = "Request header \"" + it->key + "\" value is not a string";
747 return; 747 return;
748 } 748 }
749 request.addHTTPHeaderField(AtomicString(it->key), AtomicString(value )); 749 request.addHTTPHeaderField(AtomicString(it->key), AtomicString(value ));
750 } 750 }
751 } 751 }
752 752
753 ThreadableLoaderOptions options; 753 ThreadableLoaderOptions options;
754 options.allowCredentials = AllowStoredCredentials;
755 options.crossOriginRequestPolicy = AllowCrossOriginRequests; 754 options.crossOriginRequestPolicy = AllowCrossOriginRequests;
756 755
756 ResourceLoaderOptions resourceLoaderOptions;
757 resourceLoaderOptions.allowCredentials = AllowStoredCredentials;
758
757 InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new Inspe ctorThreadableLoaderClient(callback); 759 InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new Inspe ctorThreadableLoaderClient(callback);
758 RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(* document, inspectorThreadableLoaderClient, request, options); 760 RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(* document, inspectorThreadableLoaderClient, request, options, resourceLoaderOptio ns);
759 if (!loader) { 761 if (!loader) {
760 inspectorThreadableLoaderClient->didFailLoaderCreation(); 762 inspectorThreadableLoaderClient->didFailLoaderCreation();
761 return; 763 return;
762 } 764 }
763 loader->setDefersLoading(false); 765 loader->setDefersLoading(false);
764 if (!callback->isActive()) 766 if (!callback->isActive())
765 return; 767 return;
766 inspectorThreadableLoaderClient->setLoader(loader.release()); 768 inspectorThreadableLoaderClient->setLoader(loader.release());
767 } 769 }
768 770
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 InspectorResourceAgent::InspectorResourceAgent(InspectorPageAgent* pageAgent) 814 InspectorResourceAgent::InspectorResourceAgent(InspectorPageAgent* pageAgent)
813 : InspectorBaseAgent<InspectorResourceAgent>("Network") 815 : InspectorBaseAgent<InspectorResourceAgent>("Network")
814 , m_pageAgent(pageAgent) 816 , m_pageAgent(pageAgent)
815 , m_frontend(0) 817 , m_frontend(0)
816 , m_resourcesData(adoptPtr(new NetworkResourcesData())) 818 , m_resourcesData(adoptPtr(new NetworkResourcesData()))
817 , m_isRecalculatingStyle(false) 819 , m_isRecalculatingStyle(false)
818 { 820 {
819 } 821 }
820 822
821 } // namespace WebCore 823 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698