Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 301243009: Revert of Revert of Prevent <canvas> destructor from causing nested garbage collection (Closed)

Created:
6 years, 6 months ago by Julien - ping for review
Modified:
6 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, dshwang, jbroman
Visibility:
Public.

Description

Revert of Revert of Prevent <canvas> destructor from causing nested garbage collection (https://codereview.chromium.org/307013006/) Reason for revert: This isn't the right CL, was off-by-one. Original issue's description: > Revert of Prevent <canvas> destructor from causing nested garbage collection (https://codereview.chromium.org/303803002/) > > Reason for revert: > This change is the cause of a > leak in PhishingDOMFeatureExtractorTest.ScriptAndImageFeatures > under LSAN. See > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2642/steps/browser_tests/logs/ScriptAndImageFeatures > > Original issue's description: > > Prevent <canvas> destructor from causing nested garbage collection > > > > In the destruction of HTMLCanvasElement, we call > > HTMLCanvasElement::existingDrawingContext(), whose behavior was changed > > incorrectly in r162330 and was triggering the allocation of an ImageBuffer > > during tear-down. This is not only wasteful, but it can trigger a > > garbage collection because the creation of an ImageBuffer will increase > > the amount of externallay allocated memory that is declared to V8. > > Triggering a GC during the finalization of a garbage collected object > > is bad. > > > > BUG=378289 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174984 > > TBR=senorblanco@chromium.org,junov@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=378289 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175157 TBR=senorblanco@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=378289 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Created Revert of Revert of Prevent <canvas> destructor from causing nested garbage collection
6 years, 6 months ago (2014-05-30 22:16:12 UTC) #1
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-05-30 22:16:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/301243009/1
6 years, 6 months ago (2014-05-30 22:17:33 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:18:16 UTC) #4
Message was sent while issue was closed.
Change committed as 175158

Powered by Google App Engine
This is Rietveld 408576698