Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 301243005: gpu: Add disable_arb_sync workaround and blacklist some MacOSX drivers. (Closed)

Created:
6 years, 6 months ago by reveman
Modified:
6 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

gpu: Add disable_arb_sync workaround and blacklist some MacOSX drivers. BUG=371530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274004

Patch Set 1 #

Total comments: 2

Patch Set 2 : small FeatureInfo::InitializeFeatures cleanup #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M gpu/command_buffer/service/feature_info.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
Must be ARB_sync that is broken with these drivers as I checked a few devices ...
6 years, 6 months ago (2014-05-30 03:34:32 UTC) #1
no sievers
lgtm https://codereview.chromium.org/301243005/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/301243005/diff/1/gpu/command_buffer/service/feature_info.cc#newcode809 gpu/command_buffer/service/feature_info.cc:809: arb_sync = gfx::g_driver_gl.ext.b_GL_ARB_sync; ultra-nit: I guess you could ...
6 years, 6 months ago (2014-05-30 18:05:19 UTC) #2
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 6 months ago (2014-05-30 19:16:12 UTC) #3
reveman
https://codereview.chromium.org/301243005/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/301243005/diff/1/gpu/command_buffer/service/feature_info.cc#newcode809 gpu/command_buffer/service/feature_info.cc:809: arb_sync = gfx::g_driver_gl.ext.b_GL_ARB_sync; On 2014/05/30 18:05:20, sievers wrote: > ...
6 years, 6 months ago (2014-05-30 19:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/301243005/40001
6 years, 6 months ago (2014-05-30 19:18:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 00:09:58 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:06:24 UTC) #7
Message was sent while issue was closed.
Change committed as 274004

Powered by Google App Engine
This is Rietveld 408576698