Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 301243002: Don't inherit source sets across static libs in GN. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Don't inherit source sets across static libs in GN. Previously, source sets would be inherited up the dependency chain up to shared library or executable boundaries. But if there is a static library in the middle, it will include the code from the source set and the resulting shared library or executable will get the source set's code twice. This patch stops inheriting of source sets at static library boundaries, since the static library will include the source sets's code. BUG=377890 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M tools/gn/target.h View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M tools/gn/target_unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 6 months ago (2014-05-29 18:07:53 UTC) #1
brettw
6 years, 6 months ago (2014-05-30 16:30:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698