Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 301233007: Add GN build file for dbus. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, brettw, awong, Dirk Pranke, satorux1
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : exclude from android #

Patch Set 3 : fix for proto error - depend on protobuf_lite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A dbus/BUILD.gn View 1 2 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
I'm getting this error though: In file included from ../../dbus/message_unittest.cc:12:0: gen/protoc_out/dbus/test_proto.pb.h:12:2: error: #error This file ...
6 years, 6 months ago (2014-06-01 22:19:15 UTC) #1
tfarina
Alright, issue fixed!
6 years, 6 months ago (2014-06-01 22:33:12 UTC) #2
scottmg
lgtm
6 years, 6 months ago (2014-06-02 16:29:41 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-03 03:59:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/301233007/40001
6 years, 6 months ago (2014-06-03 04:01:47 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:48:59 UTC) #6
Message was sent while issue was closed.
Change committed as 274491

Powered by Google App Engine
This is Rietveld 408576698