Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: trunk/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 301233006: Revert 273817 "Record RenderViewContextMenu.Used histogram befor..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc
===================================================================
--- trunk/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc (revision 274145)
+++ trunk/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc (working copy)
@@ -1416,8 +1416,6 @@
void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
command_executed_ = true;
- RecordUsedItem(id);
-
// If this command is is added by one of our observers, we dispatch it to the
// observer.
ObserverListBase<RenderViewContextMenuObserver>::Iterator it(observers_);
@@ -1427,6 +1425,8 @@
return observer->ExecuteCommand(id);
}
+ RecordUsedItem(id);
+
RenderFrameHost* render_frame_host =
RenderFrameHost::FromID(render_process_id_, render_frame_id_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698