Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 301233005: Removes useage of deprecated Compositor constructor (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Removes useage of deprecated Compositor constructor I'm doing to ultimately remove ContextFactory::Set/GetInstance(). BUG=none TEST=none R=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/browser/compositor/browser_compositor_view_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/compositor/image_transport_factory_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 6 months ago (2014-05-30 17:49:06 UTC) #1
piman
lgtm
6 years, 6 months ago (2014-05-30 17:58:35 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-05-30 17:59:10 UTC) #3
sky
On 2014/05/30 17:58:35, piman OOO back 2014-6-09 wrote: > lgtm HA! I wanted to send ...
6 years, 6 months ago (2014-05-30 18:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/301233005/1
6 years, 6 months ago (2014-05-30 18:00:45 UTC) #5
piman
On Fri, May 30, 2014 at 8:00 PM, <sky@chromium.org> wrote: > On 2014/05/30 17:58:35, piman ...
6 years, 6 months ago (2014-05-30 18:04:35 UTC) #6
sky
On Fri, May 30, 2014 at 11:04 AM, Antoine Labour <piman@chromium.org> wrote: > > > ...
6 years, 6 months ago (2014-05-30 18:09:26 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 00:41:03 UTC) #8
Message was sent while issue was closed.
Change committed as 273962

Powered by Google App Engine
This is Rietveld 408576698