Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 301233004: Send visit time with HISTORY_URL_VISITED notification. (Closed)

Created:
6 years, 6 months ago by nilesh
Modified:
6 years, 6 months ago
Reviewers:
haaawk1, brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Send visit time with HISTORY_URL_VISITED notification. BUG=362595 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273760

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename time to visit_time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/history/history_backend.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_notifications.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nilesh
Hi Brett, Please take a look.
6 years, 6 months ago (2014-05-29 21:22:07 UTC) #1
haaawk1
On 2014/05/29 21:22:07, nilesh wrote: > Hi Brett, Please take a look.
6 years, 6 months ago (2014-05-29 21:41:56 UTC) #2
haaawk1
lgtm
6 years, 6 months ago (2014-05-29 21:43:52 UTC) #3
brettw
lgtm https://codereview.chromium.org/301233004/diff/1/chrome/browser/history/history_notifications.h File chrome/browser/history/history_notifications.h (right): https://codereview.chromium.org/301233004/diff/1/chrome/browser/history/history_notifications.h#newcode36 chrome/browser/history/history_notifications.h:36: base::Time time; I think you should call this ...
6 years, 6 months ago (2014-05-29 23:21:01 UTC) #4
nilesh
Thanks Brett. https://codereview.chromium.org/301233004/diff/1/chrome/browser/history/history_notifications.h File chrome/browser/history/history_notifications.h (right): https://codereview.chromium.org/301233004/diff/1/chrome/browser/history/history_notifications.h#newcode36 chrome/browser/history/history_notifications.h:36: base::Time time; On 2014/05/29 23:21:02, brettw wrote: ...
6 years, 6 months ago (2014-05-29 23:29:07 UTC) #5
nilesh
The CQ bit was checked by nileshagrawal@chromium.org
6 years, 6 months ago (2014-05-29 23:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/301233004/20001
6 years, 6 months ago (2014-05-29 23:32:30 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 04:17:15 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 08:07:43 UTC) #9
Message was sent while issue was closed.
Change committed as 273760

Powered by Google App Engine
This is Rietveld 408576698