Deliver RenderCallbackErrors even when mixer inputs are paused.

media/base/audio_renderer_mixer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MSVC++ requires this to be set before any other includes to get M_PI.
 #define _USE_MATH_DEFINES
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 33 matching lines @@
         half_fill_(false) {
     // Create input and output parameters based on test parameters.
     input_parameters_ = AudioParameters(
         AudioParameters::AUDIO_PCM_LINEAR, kChannelLayout,
         std::tr1::get<0>(GetParam()), kBitsPerChannel, kHighLatencyBufferSize);
     output_parameters_ = AudioParameters(
         AudioParameters::AUDIO_PCM_LOW_LATENCY, kChannelLayout,
         std::tr1::get<1>(GetParam()), 16, kLowLatencyBufferSize);
 
     sink_ = new MockAudioRendererSink();
-    EXPECT_CALL(*sink_.get(), Start());
-    EXPECT_CALL(*sink_.get(), Stop());
+    EXPECT_CALL(*sink_, Start());
+    EXPECT_CALL(*sink_, Stop());
 
     mixer_.reset(new AudioRendererMixer(
         input_parameters_, output_parameters_, sink_));
     mixer_callback_ = sink_->callback();
 
     audio_bus_ = AudioBus::Create(output_parameters_);
     expected_audio_bus_ = AudioBus::Create(output_parameters_);
 
     // Allocate one callback for generating expected results.
     double step = kSineCycles / static_cast<double>(
@@ skipping 320 matching lines @@
     mixer_inputs_[i]->Start();
     mixer_inputs_[i]->Play();
     EXPECT_CALL(*fake_callbacks_[i], OnRenderError()).Times(1);
   }
 
   mixer_callback_->OnRenderError();
   for (size_t i = 0; i < mixer_inputs_.size(); ++i)
     mixer_inputs_[i]->Stop();
 }
 
+TEST_P(AudioRendererMixerBehavioralTest, OnRenderErrorPausedInput) {
+  InitializeInputs(kMixerInputs);
+
+  for (size_t i = 0; i < mixer_inputs_.size(); ++i)
+    EXPECT_CALL(*fake_callbacks_[i], OnRenderError()).Times(1);
+
+  // Fire the error before attaching any inputs.  Ensure an error is recieved
+  // even if the input is not connected.
+  mixer_callback_->OnRenderError();
+
+  for (size_t i = 0; i < mixer_inputs_.size(); ++i)
+    mixer_inputs_[i]->Stop();
+}
+
 // Ensure constructing an AudioRendererMixerInput, but not initializing it does
 // not call RemoveMixer().
 TEST_P(AudioRendererMixerBehavioralTest, NoInitialize) {
   EXPECT_CALL(*this, RemoveMixer(testing::_)).Times(0);
   scoped_refptr<AudioRendererMixerInput> audio_renderer_mixer =
       new AudioRendererMixerInput(
           base::Bind(&AudioRendererMixerTest::GetMixer,
                      base::Unretained(this)),
           base::Bind(&AudioRendererMixerTest::RemoveMixer,
                      base::Unretained(this)));
@@ skipping 52 matching lines @@
 
 // Test cases for behavior which is independent of parameters.  Values() doesn't
 // support single item lists and we don't want these test cases to run for every
 // parameter set.
 INSTANTIATE_TEST_CASE_P(
     AudioRendererMixerBehavioralTest, AudioRendererMixerBehavioralTest,
     testing::ValuesIn(std::vector<AudioRendererMixerTestData>(
         1, std::tr1::make_tuple(44100, 44100, 0))));
 
 }  // namespace media