Issue 301223004: Fix loading PDFs with no HTTP response headers in OOP PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301223004: Fix loading PDFs with no HTTP response headers in OOP PDF (Closed)

Created:
6 years, 6 months ago by raymes

Modified:
6 years, 6 months ago

Reviewers:
gene

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix loading PDFs with no HTTP response headers in OOP PDF Currently if no response headers are passed into the plugin in OOP PDF then the headers fetched URLLoader that loaded the stream URL will be used, but the MIME type for the blob URL is always plain text, which causes the document loader to refuse to load the document. Currently, if no headers are passed to the in process plugin, we always try to load the document, so this just mimics that behavior in the OOP plugin. When the in-process plugin is removed we can change the document loader and remove the hack. This also removes blob: URLs from the MIME type check in document loader because they are no longer ever passed in. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274081

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	pdf/document_loader.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	pdf/out_of_process_instance.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/301223004/20001

6 years, 6 months ago (2014-05-31 02:00:15 UTC) #4

Message was sent while issue was closed.

Change committed as 274081

Expand Messages | Collapse Messages