Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: sdk/lib/async/broadcast_stream_controller.dart

Issue 301193010: Update documentation for "close". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove spurious future Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/async/stream.dart » ('j') | sdk/lib/async/stream.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/broadcast_stream_controller.dart
diff --git a/sdk/lib/async/broadcast_stream_controller.dart b/sdk/lib/async/broadcast_stream_controller.dart
index 18ff6543f1067fb57f2cee52b341e4dbe20fc3da..5ec2756f1fbe3e93a8083bd6b5795c924f0e0b24 100644
--- a/sdk/lib/async/broadcast_stream_controller.dart
+++ b/sdk/lib/async/broadcast_stream_controller.dart
@@ -39,7 +39,6 @@ class _BroadcastSubscription<T> extends _ControllerSubscription<T>
bool _expectsEvent(int eventId) =>
(_eventState & _STATE_EVENT_ID) == eventId;
-
void _toggleEventId() {
_eventState ^= _STATE_EVENT_ID;
}
@@ -181,7 +180,7 @@ abstract class _BroadcastStreamController<T>
StreamSubscription<T> _subscribe(bool cancelOnError) {
if (isClosed) {
- throw new StateError("Subscribing to closed stream");
+ return new _DoneStreamSubscription<T>(_nullDoneHandler);
}
StreamSubscription subscription =
new _BroadcastSubscription<T>(this, cancelOnError);
« no previous file with comments | « no previous file | sdk/lib/async/stream.dart » ('j') | sdk/lib/async/stream.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698