Issue 301193005: Fix Windows build, add Sandbox implementation.

Issue 301193005: Fix Windows build, add Sandbox implementation. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Windows build, add Sandbox implementation. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274160

Patch Set 3 : comment out sandbox, still needs work #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -6 lines)			Patch
M	BUILD.gn	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	sandbox/win/BUILD.gn	View	1	1 chunk	+285 lines, -0 lines	0 comments	Download
M	sql/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/secondary/third_party/angle/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/child/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/301193005/diff/1/sandbox/win/BUILD.gn File sandbox/win/BUILD.gn (right): https://codereview.chromium.org/301193005/diff/1/sandbox/win/BUILD.gn#newcode144 sandbox/win/BUILD.gn:144: "src/sidestep\ia32_modrm_map.cpp", / here instead of \ https://codereview.chromium.org/301193005/diff/1/sandbox/win/BUILD.gn#newcode271 sandbox/win/BUILD.gn:271: ...

6 years, 6 months ago (2014-05-31 06:11:15 UTC) #2

brettw

https://codereview.chromium.org/301193005/diff/1/sandbox/win/BUILD.gn File sandbox/win/BUILD.gn (right): https://codereview.chromium.org/301193005/diff/1/sandbox/win/BUILD.gn#newcode271 sandbox/win/BUILD.gn:271: sources = [ On 2014/05/31 06:11:15, scottmg wrote: > ...

6 years, 6 months ago (2014-05-31 16:30:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r274160.

Expand Messages | Collapse Messages