Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 301193002: Support Bluetooth network connection type on ChromeOS. (Closed)

Created:
6 years, 6 months ago by jkarlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, keybuk
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth
Visibility:
Public.

Description

Support Bluetooth network connection type on ChromeOS. BUG=378785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jkarlin
Thanks!
6 years, 6 months ago (2014-06-05 16:57:13 UTC) #1
armansito
quiche@, stevenjb@: Do you guys know if shill actually ever returns the "Bluetooth" connection type? ...
6 years, 6 months ago (2014-06-05 18:55:55 UTC) #2
stevenjb
I don't think so, Paul?
6 years, 6 months ago (2014-06-05 19:42:20 UTC) #3
mukesh agrawal
On 2014/06/05 19:42:20, stevenjb wrote: > I don't think so, Paul? I'm not Paul, but ...
6 years, 6 months ago (2014-06-05 21:40:52 UTC) #4
armansito
This is a very small change and it seems to use the correct shill API ...
6 years, 6 months ago (2014-06-05 22:42:33 UTC) #5
jkarlin
On 2014/06/05 22:42:33, armansito wrote: > This is a very small change and it seems ...
6 years, 6 months ago (2014-06-06 14:27:30 UTC) #6
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 6 months ago (2014-06-06 14:27:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/301193002/1
6 years, 6 months ago (2014-06-06 14:28:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:53:21 UTC) #9
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 6 months ago (2014-06-06 17:53:22 UTC) #10
jkarlin
6 years, 6 months ago (2014-06-06 17:58:13 UTC) #11
Message was sent while issue was closed.
On 2014/06/06 17:53:22, I haz the power (commit-bot) wrote:
> Could not make sense out of svn commit message.

Seems to be r275473.

Powered by Google App Engine
This is Rietveld 408576698