Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 301183005: Make the bridge_id in WebGeolocationPermissionRequestManager be unique per process. (Closed)

Created:
6 years, 6 months ago by jam
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, dglazkov+blink, jamesr, timvolodine, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make the bridge_id in WebGeolocationPermissionRequestManager be unique per process. Right now it's unique per view, but as part of converting the content side code to use frames instead of views in https://codereview.chromium.org/303503008/ we need this to be unique per view. That can change back in the future once all the permission-related code in the browser (PermissionRequestID in particular) is converted. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175167

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/web/WebGeolocationPermissionRequestManager.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M public/web/WebGeolocationPermissionRequestManager.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jam
6 years, 6 months ago (2014-05-30 07:11:41 UTC) #1
jam
switching to dglazkov since jochen is out
6 years, 6 months ago (2014-05-30 15:13:21 UTC) #2
dglazkov
lgtm https://codereview.chromium.org/301183005/diff/1/Source/web/WebGeolocationPermissionRequestManager.cpp File Source/web/WebGeolocationPermissionRequestManager.cpp (right): https://codereview.chromium.org/301183005/diff/1/Source/web/WebGeolocationPermissionRequestManager.cpp#newcode49 Source/web/WebGeolocationPermissionRequestManager.cpp:49: static int lastId; Ideally, there's a static function ...
6 years, 6 months ago (2014-05-30 18:31:42 UTC) #3
jam
The CQ bit was checked by jam@chromium.org
6 years, 6 months ago (2014-05-30 19:14:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/301183005/1
6 years, 6 months ago (2014-05-30 19:15:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-30 19:49:36 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:53:51 UTC) #7
Message was sent while issue was closed.
Change committed as 175167

Powered by Google App Engine
This is Rietveld 408576698