Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: build/android/pylib/device/device_list.py

Issue 301183004: Android: adds device affinity for perf tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/device/device_list.py
diff --git a/build/android/pylib/device/device_list.py b/build/android/pylib/device/device_list.py
new file mode 100644
index 0000000000000000000000000000000000000000..5c5cf732a0a1bf4021072bdb59e538323dcdde5c
--- /dev/null
+++ b/build/android/pylib/device/device_list.py
@@ -0,0 +1,36 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""A module to keep track of devices across builds."""
jbudorick 2014/06/03 13:52:52 I'm not sure that this module goes far enough - it
+
+import os
+
+LAST_DEVICES_FILENAME = '.last_devices'
+LAST_MISSING_DEVICES_FILENAME = '.last_missing'
+
+
+def GetDeviceList(file_name):
jbudorick 2014/06/03 13:52:52 This should be renamed to avoid confusion with Adb
bulach 2014/06/03 14:25:52 good point! Get|WritePersistentDeviceList.
+ """Returns a list of devices.
+
+ Args:
+ file_name: the file name containing a list of devices.
+
+ Returns: List of device serial numbers that were on the bot.
+ """
+ devices = []
+ try:
+ with open(file_name) as f:
+ devices = f.read().splitlines()
+ except IOError:
+ # Ignore error, file might not exist
+ pass
jbudorick 2014/06/03 13:52:52 This should log something. Not an error, obviously
bulach 2014/06/03 14:25:52 good catch.. the exception shouldn't be handled he
+ return devices
+
+
+def WriteDeviceList(file_name, device_list):
+ path = os.path.dirname(file_name)
+ if not os.path.exists(path):
+ os.makedirs(path)
+ with open(file_name, 'w') as f:
+ f.write('\n'.join(set(device_list)))

Powered by Google App Engine
This is Rietveld 408576698