Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 3011813002: Updated sanitizeCategory to better account for category names. (Closed)

Created:
3 years, 3 months ago by mkroghj
Modified:
3 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated sanitizeCategory to better account for category names. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/9f9aafc3378fe15a9bb416f160ff7ed2b274e7cf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Modified sanitizeCategory to accout for different lengths of channel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/gardening/lib/src/util.dart View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mkroghj
ptal
3 years, 3 months ago (2017-09-01 09:36:15 UTC) #2
mkroghj
ptal
3 years, 3 months ago (2017-09-01 09:37:08 UTC) #4
Bill Hesse
lgtm https://codereview.chromium.org/3011813002/diff/1/tools/gardening/lib/src/util.dart File tools/gardening/lib/src/util.dart (right): https://codereview.chromium.org/3011813002/diff/1/tools/gardening/lib/src/util.dart#newcode111 tools/gardening/lib/src/util.dart:111: // Category name starts with a channel number ...
3 years, 3 months ago (2017-09-01 11:10:57 UTC) #5
mkroghj
Committed patchset #2 (id:20001) manually as 9f9aafc3378fe15a9bb416f160ff7ed2b274e7cf (presubmit successful).
3 years, 3 months ago (2017-09-01 11:37:12 UTC) #7
mkroghj
3 years, 3 months ago (2017-09-01 11:37:34 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/3011813002/diff/1/tools/gardening/lib/src/uti...
File tools/gardening/lib/src/util.dart (right):

https://codereview.chromium.org/3011813002/diff/1/tools/gardening/lib/src/uti...
tools/gardening/lib/src/util.dart:111: // Category name starts with a channel
number (normally consisting of 1-3
On 2017/09/01 11:10:57, Bill Hesse wrote:
> LGTM, but could you just regexp match $[0-9]+(.*)\|all^ and take the matching
> group 1 in parentheses?

swapped $ and ^.

Done

Powered by Google App Engine
This is Rietveld 408576698