Add types referenced in is-checks to the class hierarchy

pkg/compiler/lib/src/universe/resolution_world_builder.dart

Index: pkg/compiler/lib/src/universe/resolution_world_builder.dart
diff --git a/pkg/compiler/lib/src/universe/resolution_world_builder.dart b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
index a2b023590561949a2a8f0be4a6b67f45f9ccd1cf..f1c78c672e355d037d1b1f9d58c8f1d388943d37 100644
--- a/pkg/compiler/lib/src/universe/resolution_world_builder.dart
+++ b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
@@ -319,6 +319,8 @@ abstract class ResolutionWorldBuilderBase
   final Set<FieldEntity> fieldSetters = new Set<FieldEntity>();
   final Set<DartType> isChecks = new Set<DartType>();
 
+  _ClassEnsurer _classEnsurer;
+
   /// Set of all closures in the program. Used by the mirror tracking system
   /// to find all live closure instances.
   final Set<Local> localFunctions = new Set<Local>();
@@ -392,7 +394,9 @@ abstract class ResolutionWorldBuilderBase
       this._backendUsageBuilder,
       this._rtiNeedBuilder,
       this._nativeResolutionEnqueuer,
-      this.selectorConstraintsStrategy);
+      this.selectorConstraintsStrategy) {
+    _classEnsurer = new _ClassEnsurer(this);
+  }
 
   Iterable<ClassEntity> get processedClasses => _processedClasses.keys
       .where((cls) => _processedClasses[cls].isInstantiated);
@@ -944,6 +948,24 @@ abstract class ResolutionWorldBuilderBase
     // variables to the super constructor.
     forEachInstantiatedClass(addSubtypes);
 
+    instantiatedTypes.forEach((type) {
+      var callType = _dartTypes.getCallType(type);
+      if (callType != null) {
+        _classEnsurer.ensureClassesInType(callType);
+      }
+    });
+    localFunctions.forEach((function) {
+      _classEnsurer.ensureClassesInType(
+          _elementEnvironment.getLocalFunctionType(function));
+    });
+    isChecks.forEach((t) {

[Siggi Cherem (dart-lang), 2017/09/01 19:05:12]

nit: isChecks.forEach(_classEnsurer.ensureClassesInType);

[Harry Terkelsen, 2017/09/01 21:48:57]

Done.

+      _classEnsurer.ensureClassesInType(t);
+    });
+    closurizedMembers.forEach((function) {

[Siggi Cherem (dart-lang), 2017/09/01 19:05:12]

I'm surprised we were missing so many here. This code path was also used in the
old compiler pipeline, how come it is not missing types for all of these as
well?

[Johnni Winther, 2017/09/01 19:59:56]

Because ClassElement.ensureResolved registers the class with the class
hierarchy.

[Harry Terkelsen, 2017/09/01 21:25:33]

The old pipeline adds classes to the hierarchy as it resolves them. This way
adds them based on the impacts after resolution.

+      _classEnsurer
+          .ensureClassesInType(_elementEnvironment.getFunctionType(function));
+    });
+
     _classHierarchyNodes.keys.toList().forEach(_ensureClassSet);
 
     return typesImplementedBySubclasses;
@@ -1030,3 +1052,39 @@ abstract class KernelResolutionWorldBuilderBase
     throw new UnimplementedError('KernelResolutionWorldBuilder.registerClass');
   }
 }
+
+// TODO(het): Make this have a type of BaseDartTypeVisitor<void, Null>
+class _ClassEnsurer extends BaseDartTypeVisitor<dynamic, Null> {
+  final ResolutionWorldBuilderBase worldBuilder;
+
+  _ClassEnsurer(this.worldBuilder);
+
+  void ensureClassesInType(DartType type) {
+    type.accept(this, null);
+  }
+
+  @override
+  visitType(DartType type, _) {}
+
+  @override
+  visitFunctionType(FunctionType type, _) {
+    type.returnType.accept(this, null);
+    type.parameterTypes.forEach((t) {
+      t.accept(this, null);
+    });
+    type.optionalParameterTypes.forEach((t) {
+      t.accept(this, null);
+    });
+    type.namedParameterTypes.forEach((t) {
+      t.accept(this, null);
+    });
+  }
+
+  @override
+  visitInterfaceType(InterfaceType type, _) {
+    worldBuilder._ensureClassSet(type.element);
+    type.typeArguments.forEach((t) {
+      t.accept(this, null);
+    });
+  }
+}