Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3011763002: fix #30591, ensure all extension methods are generated (Closed)

Created:
3 years, 3 months ago by Jennifer Messerly
Modified:
3 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #30591, ensure all extension methods are generated R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/c1e58bfb6981ba78ea6e248ba74411aee42b6aa5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +25 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
3 years, 3 months ago (2017-08-31 20:58:01 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/3011763002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/3011763002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode1994 pkg/dev_compiler/lib/src/compiler/code_generator.dart:1994: _declareMemberName(m.element, useExtension: true); FYI, this is mostly the original ...
3 years, 3 months ago (2017-08-31 21:00:48 UTC) #3
Leaf
lgtm
3 years, 3 months ago (2017-08-31 21:07:32 UTC) #5
Jennifer Messerly
3 years, 3 months ago (2017-08-31 21:20:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c1e58bfb6981ba78ea6e248ba74411aee42b6aa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698