Issue 301173007: Replaced options from QuicPacketCreator with members and explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301173007: Replaced options from QuicPacketCreator with members and explicit (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Jana, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replaced options from QuicPacketCreator with members and explicit getters/setters. A couple of small bugs fixed. Merge internal change: 68099048 R=jri@chromium.org, rch@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+210 lines, -199 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	23 chunks	+61 lines, -50 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_packet_creator.h	View	6 chunks	+55 lines, -33 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	12 chunks	+31 lines, -42 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	12 chunks	+30 lines, -34 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	net/quic/quic_session.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/reliable_quic_stream_test.cc	View	3 chunks	+15 lines, -11 lines	0 comments	Download
M	net/tools/quic/quic_client.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_client.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_client.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_client.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Apologies for the delay.

Expand Messages | Collapse Messages