Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 301173006: Move NoEventDispatchAssertion class to its own file (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, blink-reviews-events_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Move NoEventDispatchAssertion class to its own file Move NoEventDispatchAssertion class to its own file instead of having it in ContainerNode.h. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175282

Patch Set 1 #

Patch Set 2 : Add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -59 lines) Patch
M Source/core/dom/ContainerNode.h View 2 chunks +0 lines, -58 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/dom/NoEventDispatchAssertion.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/UndoStack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 6 months ago (2014-06-02 01:14:26 UTC) #1
eseidel
lgtm You are such a fantastic contributor to blink. Thank you.
6 years, 6 months ago (2014-06-02 05:22:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/301173006/20001
6 years, 6 months ago (2014-06-02 05:22:58 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-02 05:45:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 05:45:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12736)
6 years, 6 months ago (2014-06-02 05:45:43 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-02 13:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/301173006/20001
6 years, 6 months ago (2014-06-02 13:11:07 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 14:19:11 UTC) #9
Message was sent while issue was closed.
Change committed as 175282

Powered by Google App Engine
This is Rietveld 408576698