Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: gyp/common_variables.gypi

Issue 301173002: cleanup gyp common_variables (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_variables.gypi
diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi
index 61efe92eecaf1103f20eccbff1336903267c462c..c8b069ce685345a075b37995c6de40b4eda59085 100644
--- a/gyp/common_variables.gypi
+++ b/gyp/common_variables.gypi
@@ -48,6 +48,8 @@
'skia_android_framework%': 0,
'skia_arch_type%': 'x86',
+ 'arm_version%': 0,
+ 'arm_neon%': 0,
},
# Re-define all variables defined within the level-3 'variables' dict,
@@ -55,6 +57,8 @@
# (skia_os will depend on skia_android_framework.)
'skia_android_framework%': '<(skia_android_framework)',
'skia_arch_type%': '<(skia_arch_type)',
+ 'arm_version%': '<(arm_version)',
+ 'arm_neon%': '<(arm_neon)',
'conditions': [
[ 'skia_android_framework == 1', {
@@ -92,10 +96,6 @@
'skia_arch_type%': 'arm',
'arm_version%': 7,
'arm_neon%': 0, # neon asm files known not to work with the ios build
- },{ # skia_os is not ios
- 'skia_arch_type%': 'x86',
- 'arm_version%': 0,
- 'arm_neon%': 0,
}],
[ 'skia_os in ["android", "nacl"] and not skia_android_framework',
# skia_freetype_static - on OS variants that normally would
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698