Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 3011693002: Fasta test cleanup (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -441 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 8 chunks +0 lines, -174 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 24 chunks +219 lines, -267 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Removes a couple of tests that were duplicated. Moves all of the non-nullable by default ...
3 years, 3 months ago (2017-08-31 16:27:40 UTC) #2
danrubel
LGTM
3 years, 3 months ago (2017-08-31 17:08:57 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-31 17:10:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1e8f3b130db380b1d6b4964d3389587f72fa428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698