Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 3011663002: Restructure outline shaker tests. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restructure outline shaker tests. 1. Instead of using a single lib/lib.dart, use a couple of small shared libraries, and special libraries for each case we want to test. 2. Give tests meaningful structured names, with "source_*" tests testing that we take into account referenced *from* somewhere. And "target_*" tests for testing that we include referenced entities. And "transitive_*" tests for including complete transitive closure of referenced entities. We don't yet include full transitive closure, this CL is just for tests and results produced at the moment. Implementation and test fixes will follow. We also don't yet take exports into account. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/37b301e21a1073ad88e2337d24023c0f270f3a53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -320 lines) Patch
M pkg/front_end/test/fasta/shaker_test.dart View 3 chunks +2 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/shaker/classes_in_signatures.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/classes_in_signatures.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/implicit_constructors.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/implicit_constructors.dart.shaker View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_bounds.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_bounds.dart.shaker View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_field_type.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_field_type.dart.shaker View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/shaker/lib/lib.dart View 1 chunk +0 lines, -35 lines 0 comments Download
A pkg/front_end/testcases/shaker/lib/sources.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/shaker/lib/targets_top.dart View 1 chunk +11 lines, -0 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots0.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots0.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots1.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots1.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots2.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots2.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots3.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots3.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots4.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots4.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots5.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots5.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots6.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots6.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots7.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots7.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
A + pkg/front_end/testcases/shaker/source_class.dart View 1 chunk +10 lines, -5 lines 0 comments Download
A pkg/front_end/testcases/shaker/source_class.dart.shaker View 1 chunk +12 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/source_local.dart View 1 chunk +7 lines, -3 lines 0 comments Download
A + pkg/front_end/testcases/shaker/source_local.dart.shaker View 1 chunk +3 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/shaker/source_top.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/shaker/source_top.dart.shaker View 1 chunk +19 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_top_class.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_top_class.dart.shaker View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_top_function.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_top_function.dart.shaker View 1 chunk +5 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_top_function_type_alias.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_top_function_type_alias.dart.shaker View 1 chunk +5 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_top_variable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_top_variable.dart.shaker View 1 chunk +5 lines, -0 lines 0 comments Download
D pkg/front_end/testcases/shaker/toplevel_reference.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/toplevel_reference.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class.dart View 1 chunk +2 lines, -4 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class.dart.shaker View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class_constructor.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/shaker/transitive_class_constructor.dart.shaker View 1 chunk +9 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class_constructor_lib.dart View 1 chunk +18 lines, -5 lines 0 comments Download
A pkg/front_end/testcases/shaker/transitive_class_lib.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class_type_parameter_bound.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/shaker/transitive_class_type_parameter_bound.dart.shaker View 1 chunk +6 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_class_type_parameter_bound_lib.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_mixins.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_mixins.dart.shaker View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_mixins_lib.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_superclass.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_superclass.dart.shaker View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/front_end/testcases/shaker/transitive_superclass_lib.dart View 1 chunk +4 lines, -4 lines 0 comments Download
D pkg/front_end/testcases/shaker/typedefs_in_types.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/shaker/typedefs_in_types.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/front_end/testing.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 3 months ago (2017-08-30 20:20:56 UTC) #1
Paul Berry
lgtm
3 years, 3 months ago (2017-08-30 20:29:04 UTC) #2
scheglov
3 years, 3 months ago (2017-08-30 20:33:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37b301e21a1073ad88e2337d24023c0f270f3a53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698