Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 3011653002: More bot breakage fixes, covering these cases: (Closed)

Created:
3 years, 3 months ago by jcollins
Modified:
3 years, 3 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More bot breakage fixes, covering these cases: python tools/test.py -m release -c dart2js -r d8 --checked --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test python tools/test.py -m release -c dart2js -r d8 --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/typedef_is_test python tools/test.py -m release -c dart2js -r d8 --minified --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/async_await_catch_stacktrace_test BUG= R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/ea523a59b7b6495cf7874c2e8818a2beb5bbc241

Patch Set 1 #

Patch Set 2 : More bot breakage fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tests/language_2/language_2_dart2js.status View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jcollins
3 years, 3 months ago (2017-08-30 20:07:44 UTC) #2
bkonyi
LGTM, at least as far as I can tell :)
3 years, 3 months ago (2017-08-30 20:10:54 UTC) #3
jcollins
3 years, 3 months ago (2017-08-30 20:15:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ea523a59b7b6495cf7874c2e8818a2beb5bbc241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698