Fix several failing tests

Fix several failing tests

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a48eff924bf5b4d1262982e87e5cfd3540b27a2

[Brian Wilkerson, 2017-08-30 16:04:19]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com

[Brian Wilkerson, 2017-08-30 16:04:19]

First set of changes to get the tests to pass.

[danrubel, 2017-08-30 16:15:50]

I have no idea what changed in ast_builder.dart. If you'd like to sort the
methods in a class, please submit that as a separate CL.

FWIW, all of the other fasta parser listeners have begin and end methods kept
together in the source so that it's easier to see what's pushed onto the stack
and what's popped off of the stack.

[Brian Wilkerson, 2017-08-30 16:17:04]

https://codereview.chromium.org/3011643002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_fasta_test.dart (right):

https://codereview.chromium.org/3011643002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_fasta_test.dart:2814: List metadata =
_run((parser) => parser.parseMetadataStar, nodeCount: -1);
I think this method is wrong. After looking at the code more I think
`parseMetadataStar` will always return a two element list, the first element
being either a `Comment` or a `NullValue` and that the second element will
always be either a `List<Annotation>` or a `NullValue`. I can either fix it now
or in a separate CL.

[danrubel, 2017-08-30 16:18:17]

https://codereview.chromium.org/3011643002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_fasta_test.dart (right):

https://codereview.chromium.org/3011643002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_fasta_test.dart:2814: List metadata =
_run((parser) => parser.parseMetadataStar, nodeCount: -1);
On 2017/08/30 16:17:03, Brian Wilkerson wrote:
> I think this method is wrong. After looking at the code more I think
> `parseMetadataStar` will always return a two element list, the first element
> being either a `Comment` or a `NullValue` and that the second element will
> always be either a `List<Annotation>` or a `NullValue`. I can either fix it
now
> or in a separate CL.

Smaller CLs are better in general.

[Brian Wilkerson, 2017-08-30 16:19:58]

> I have no idea what changed in ast_builder.dart. If you'd like to sort the
methods in a class, please submit that as a separate CL.

Sorry about that! The sort was unintentional (even though we have a policy for
code in the analyzer-related packages to always sort).

I'll back out the sorting changes.

[Brian Wilkerson, 2017-08-30 16:47:19]

ptal

Unintentional sorting backed out.
The parseCommentAndMetadata method has been fixed.

[danrubel, 2017-08-30 17:44:03]

Thank you! Much more clear and good progress! LGTM

https://codereview.chromium.org/3011643002/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3011643002/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1240: // the listener.
Is this comment still valid? Are there situations in which `rightParen` is not
')' ?

[Brian Wilkerson, 2017-08-30 18:03:49]

https://codereview.chromium.org/3011643002/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3011643002/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1240: // the listener.
I think so...

If the paren is missing, or if there are tokens between the name and the paren
that are discarded during recovery, we'll get the wrong token here. This code
should probably check the token type and set `rightParen` to null to help catch
that case. But in order to get it right, the listener really needs the parser to
send it *all* of the tokens rather than having any of them inferred by location.

[Brian Wilkerson, 2017-08-30 18:04:12]

Description was changed from

==========
Fix several failing tests
==========

to

==========
Fix several failing tests

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6a48eff924bf5b4d1262982e87e5cfd3540b27a2
==========

[Brian Wilkerson, 2017-08-30 18:04:13]

Committed patchset #2 (id:20001) manually as
6a48eff924bf5b4d1262982e87e5cfd3540b27a2 (presubmit successful).