Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3011633002: Added back helper file accidentally deleted during test block 219 migration. (Closed)

Created:
3 years, 3 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added back helper file accidentally deleted during test block 219 migration. TBR=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/36ddbead91b9c8eacd0b50eabbabe1c77d41a1e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -1898 lines) Patch
M tests/lib/lib.status View 5 chunks +8 lines, -20 lines 0 comments Download
D tests/lib/mirrors/constructor_private_name_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib/mirrors/constructors_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/lib/mirrors/dart2js_mirrors_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/lib/mirrors/declarations_model_easier.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/lib/mirrors/declarations_type_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_metadata_lib.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_metadata_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_metatarget_lib.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_metatarget_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_update_lib.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib/mirrors/deferred_mirrors_update_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib/mirrors/deferred_type_other.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/lib/mirrors/deferred_type_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/mirrors/delegate_call_through_getter_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib/mirrors/delegate_class_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/lib/mirrors/delegate_function_invocation_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/lib/mirrors/delegate_library_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/lib/mirrors/delegate_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/lib/mirrors/disable_tree_shaking_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/lib/mirrors/empty.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/lib/mirrors/empty_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib/mirrors/enum_test.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D tests/lib/mirrors/equality_test.dart View 1 chunk +0 lines, -153 lines 0 comments Download
M tests/lib_2/lib_2.status View 1 chunk +5 lines, -0 lines 0 comments Download
A tests/lib_2/lib_2_analyzer.status View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_kernel.status View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_precompiled.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_2/lib_2_vm.status View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/lib_2/mirrors/constructor_private_name_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/constructors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/dart2js_mirrors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/lib_2/mirrors/declarations_model.dart View 3 chunks +4 lines, -4 lines 0 comments Download
A + tests/lib_2/mirrors/declarations_model_easier.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/declarations_type_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_metadata_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_metadata_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_metatarget_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_metatarget_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_update_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_mirrors_update_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_type_other.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/deferred_type_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/delegate_call_through_getter_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/lib_2/mirrors/delegate_class_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
A + tests/lib_2/mirrors/delegate_function_invocation_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
A + tests/lib_2/mirrors/delegate_library_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
A + tests/lib_2/mirrors/delegate_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
A + tests/lib_2/mirrors/disable_tree_shaking_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/empty.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/empty_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/enum_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/equality_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/lib_2/mirrors/mirrors_test.dart View 1 chunk +247 lines, -0 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 3 chunks +8 lines, -17 lines 0 comments Download
M tests/lib_strong/lib_strong_kernel.status View 1 chunk +4 lines, -6 lines 0 comments Download
D tests/lib_strong/mirrors/constructor_private_name_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/lib_strong/mirrors/constructors_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D tests/lib_strong/mirrors/dart2js_mirrors_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/lib_strong/mirrors/declarations_model_easier.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/lib_strong/mirrors/declarations_type_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_metadata_lib.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_metadata_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_metatarget_lib.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_metatarget_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_update_lib.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_mirrors_update_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_type_other.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/lib_strong/mirrors/deferred_type_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib_strong/mirrors/delegate_call_through_getter_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/lib_strong/mirrors/delegate_class_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/lib_strong/mirrors/delegate_function_invocation_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/lib_strong/mirrors/delegate_library_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/lib_strong/mirrors/delegate_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/lib_strong/mirrors/disable_tree_shaking_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/lib_strong/mirrors/empty.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/lib_strong/mirrors/empty_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib_strong/mirrors/enum_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/lib_strong/mirrors/equality_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bkonyi
declarations_model.dart was added back into lib/mirrors/ and lib_strong/mirrors/
3 years, 3 months ago (2017-08-30 14:58:44 UTC) #1
bkonyi
Committed patchset #1 (id:1) manually as 36ddbead91b9c8eacd0b50eabbabe1c77d41a1e9.
3 years, 3 months ago (2017-08-30 14:59:17 UTC) #3
Dmitry Stefantsov
3 years, 3 months ago (2017-08-30 15:08:00 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698