Source/core/html/parser/XSSAuditorDelegate.cpp - Issue 301163006: Add schedulePageBlock() to navigation scheduler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/parser/XSSAuditorDelegate.cpp

Issue 301163006: Add schedulePageBlock() to navigation scheduler (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix omission. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/security/xssAuditor/window-open-block-mode-expected.txt ('k') | Source/core/loader/NavigationScheduler.h » ('j') | Source/core/loader/NavigationScheduler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google, Inc. All Rights Reserved.	2 * Copyright (C) 2013 Google, Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 if (!m_didSendNotifications) {	109 if (!m_didSendNotifications) {

110 m_didSendNotifications = true;	110 m_didSendNotifications = true;

111	111

112 frameLoader.client()->didDetectXSS(m_document->url(), xssInfo.m_didBlock EntirePage);	112 frameLoader.client()->didDetectXSS(m_document->url(), xssInfo.m_didBlock EntirePage);

113	113

114 if (!m_reportURL.isEmpty())	114 if (!m_reportURL.isEmpty())

115 PingLoader::sendViolationReport(m_document->frame(), m_reportURL, ge nerateViolationReport(xssInfo), PingLoader::XSSAuditorViolationReport);	115 PingLoader::sendViolationReport(m_document->frame(), m_reportURL, ge nerateViolationReport(xssInfo), PingLoader::XSSAuditorViolationReport);

116 }	116 }

117	117

118 if (xssInfo.m_didBlockEntirePage)	118 if (xssInfo.m_didBlockEntirePage)

119 m_document->frame()->navigationScheduler().scheduleLocationChange(m_docu ment, SecurityOrigin::urlWithUniqueSecurityOrigin(), Referrer());	119 m_document->frame()->navigationScheduler().schedulePageBlock(m_document, Referrer());
	Nate Chapin 2014/07/14 19:26:40 lockBackForwardList is an optional parameter that' lockBackForwardList is an optional parameter that's not being used here. Is there a reason we need to add schedulePageBlock() instead of just passing the extra paramater to scheduleLocationChange()? Tom Sepez 2014/07/14 19:45:49 Yes. Existing logic further down the line override Show quoted text On 2014/07/14 19:26:40, Nate Chapin wrote: > lockBackForwardList is an optional parameter that's not being used here. Is > there a reason we need to add schedulePageBlock() instead of just passing the > extra paramater to scheduleLocationChange()? Yes. Existing logic further down the line overrides the value passed for lockBackForwardList under these circumstances.
120 }	120 }

121	121

122 } // namespace WebCore	122 } // namespace WebCore

OLD	NEW