Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 301163002: Revert of Revert of Follow up change for disabling out-of-box VK overscroll (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
Reviewers:
ygorshenin1, tzik
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert of Revert of Follow up change for disabling out-of-box VK overscroll (https://codereview.chromium.org/301923002/) Reason for revert: Reverting incorrect revert. Proper revert committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=273467 Original issue's description: > Revert of Follow up change for disabling out-of-box VK overscroll (https://codereview.chromium.org/298373002/) > > Reason for revert: > This CL broke VMTest on ChromiumOS bot: > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999 > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999/steps/VMTest%20%28attempt%201%29/logs/stdio > > Original issue's description: > > Follow up change for disabling out-of-box VK overscroll > > > > Have to use CoreOobeActor through OobeUI since WebUILoginDisplay is not created during out-of-box. > > Removed changes in *LoginDisplay*. > > > > BUG=363635 > > R=ygorshenin@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273241 > > TBR=ygorshenin@chromium.org,nkostylev@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=363635 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273466 TBR=ygorshenin@chromium.org,tzik@chromium.org NOTREECHECKS=true NOTRY=true BUG=363635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -39 lines) Patch
M chrome/browser/chromeos/login/ui/login_display.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
Created Revert of Revert of Follow up change for disabling out-of-box VK overscroll
6 years, 6 months ago (2014-05-29 14:10:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/301163002/1
6 years, 6 months ago (2014-05-29 14:11:56 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 14:14:34 UTC) #3
Message was sent while issue was closed.
Change committed as 273472

Powered by Google App Engine
This is Rietveld 408576698