Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 3011553002: Add simple tests for Fasta parser (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : uncomment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1626 lines, -825 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 2 chunks +784 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 8 chunks +842 lines, -825 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
These are mostly failing because the parse methods that are being called are not implemented. ...
3 years, 3 months ago (2017-08-29 19:16:29 UTC) #2
danrubel
LGTM once comment has been addressed. https://codereview.chromium.org/3011553002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart File pkg/analyzer/test/generated/parser_fasta_test.dart (right): https://codereview.chromium.org/3011553002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart#newcode31 pkg/analyzer/test/generated/parser_fasta_test.dart:31: // defineReflectiveTests(ClassMemberParserTest_Fasta); Should ...
3 years, 3 months ago (2017-08-29 19:34:49 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/3011553002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart File pkg/analyzer/test/generated/parser_fasta_test.dart (right): https://codereview.chromium.org/3011553002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart#newcode31 pkg/analyzer/test/generated/parser_fasta_test.dart:31: // defineReflectiveTests(ClassMemberParserTest_Fasta); No, thanks! That was an oversight that ...
3 years, 3 months ago (2017-08-29 19:41:45 UTC) #4
Brian Wilkerson
3 years, 3 months ago (2017-08-29 19:42:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce952b77ab74714ac956afcda77312f227c01f89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698