Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 3011503002: Revert "Add ticks counter to Timer." (Closed)

Created:
3 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 3 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add ticks counter to Timer." Tests broken in DDC Committed: https://github.com/dart-lang/sdk/commit/c8b6c193141bc1018dc2d55d3fbfef5a13436b0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -200 lines) Patch
M pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart View 4 chunks +0 lines, -13 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/preambles/d8.js View 3 chunks +2 lines, -11 lines 0 comments Download
M runtime/lib/timer_impl.dart View 3 chunks +0 lines, -15 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 4 chunks +0 lines, -13 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/preambles/d8.js View 5 chunks +4 lines, -12 lines 0 comments Download
M sdk/lib/async/timer.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/lib_2/async/periodic_timer2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib_2/async/periodic_timer3_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/lib_2/async/periodic_timer4_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Lasse Reichstein Nielsen
3 years, 3 months ago (2017-08-28 11:14:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8b6c193141bc1018dc2d55d3fbfef5a13436b0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698