Issue 3011493002: Mark service test as runtime error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3011493002: Mark service test as runtime error (Closed)

Created:
3 years, 3 months ago by jensj

Modified:
3 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Mark service test as runtime error Snapshots don't include source and generated source is not 1-to-1. The column offset is off for this test. BUG= Committed: https://github.com/dart-lang/sdk/commit/656b495df861eadb7f6b55b153b327dbadedbe47

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/observatory/tests/service/service.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

Committed patchset #1 (id:1) manually as 656b495df861eadb7f6b55b153b327dbadedbe47 (presubmit successful).

3 years, 3 months ago (2017-08-28 10:26:32 UTC) #4

Message was sent while issue was closed.

lgtm