Issue 3011433002: Revert "Reduce use of getClosureInfoForMember and cleanup closure_test"

Issue 3011433002: Revert "Reduce use of getClosureInfoForMember and cleanup closure_test" (Closed)

Created:
3 years, 3 months ago by Emily Fortuna

Modified:
3 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Reduce use of getClosureInfoForMember and cleanup closure_test" I tried to land https://codereview.chromium.org/2998113002/ on behalf of Johnni, but it wouldn't let me update the status files, and this change modifies status files. Reverting. This reverts commit 6b3f8665c05f7e33830f6f980d13ed2e6aaf2918. BUG= Committed: https://github.com/dart-lang/sdk/commit/e94ff86b2bd237a5e007f11d9ec4c5272103e945

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -40 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_model/closure.dart	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/closure/closure_test.dart	View	6 chunks	+18 lines, -19 lines	0 comments	Download
M	tests/compiler/dart2js/closure/data/captured_variable.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/equivalence/id_equivalence_helper.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (2 generated)

Emily Fortuna

3 years, 3 months ago (2017-08-26 00:57:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e94ff86b2bd237a5e007f11d9ec4c5272103e945 (presubmit successful).