Bench Rebaseline from Codereview: separate out all_trybots_finished()

Bench Rebaseline from Codereview: separate out all_trybots_finished()

BUG=skia:2225
NOTREECHECKS=true

Committed: http://code.google.com/p/skia/source/detail?r=14951

[benchen, 2014-05-29 13:20:25]

https://codereview.chromium.org/301143002/diff/20001/tools/gen_bench_expectat...
File tools/gen_bench_expectations_from_codereview.py (right):

https://codereview.chromium.org/301143002/diff/20001/tools/gen_bench_expectat...
tools/gen_bench_expectations_from_codereview.py:125: if error_on_unfinished and
not _all_trybots_finished(try_builds):
all_trybots_finished(codereview_url) defined above are not used. try_builds are
used below. So shall we still keep the unused
all_trybots_finished(codereview_url)?

[borenet, 2014-05-29 13:21:59]

https://codereview.chromium.org/301143002/diff/20001/tools/gen_bench_expectat...
File tools/gen_bench_expectations_from_codereview.py (right):

https://codereview.chromium.org/301143002/diff/20001/tools/gen_bench_expectat...
tools/gen_bench_expectations_from_codereview.py:125: if error_on_unfinished and
not _all_trybots_finished(try_builds):
On 2014/05/29 13:20:26, benchen wrote:
> all_trybots_finished(codereview_url) defined above are not used. try_builds
are
> used below. So shall we still keep the unused
> all_trybots_finished(codereview_url)?

It's going to be used by the RecreateSKPs bot.

[benchen, 2014-05-29 13:22:59]

lgtm. Thanks for the explanation.

[borenet, 2014-05-29 13:29:24]

Just noticed another problem, uploaded patch set 3 to fix.

[benchen, 2014-05-29 13:33:26]

lgtm. so data.url could be None.

[borenet, 2014-05-29 13:42:59]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-29 13:43:37]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/301143002/30001

[borenet, 2014-05-29 14:26:42]

The CQ bit was unchecked by borenet@google.com

[borenet, 2014-05-29 14:26:56]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-29 14:27:42]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/301143002/30001

[borenet, 2014-05-29 14:30:30]

The CQ bit was unchecked by borenet@google.com

[borenet, 2014-05-29 14:30:42]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-29 14:31:22]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/301143002/30001

[commit-bot: I haz the power, 2014-05-29 14:31:31]

Change committed as 14951