Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 3011403002: [pinpoint] Add favicon. (Closed)

Created:
3 years, 3 months ago by dtu
Modified:
3 years, 2 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M dashboard/dashboard/pinpoint/elements/jobs-table.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/dashboard/pinpoint/index/index.html View 1 chunk +4 lines, -0 lines 0 comments Download
A dashboard/dashboard/pinpoint/static/logo.png View Binary file 0 comments Download
A + dashboard/dashboard/pinpoint/static/sort-down.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dashboard/dashboard/pinpoint/static/sort-up.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dashboard/dashboard/pinpoint/static/sort-up-down.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
D dashboard/dashboard/static/sort-down.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D dashboard/dashboard/static/sort-up.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D dashboard/dashboard/static/sort-up-down.svg View 1 chunk +0 lines, -12 lines 0 comments Download
M dashboard/pinpoint.yaml View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dtu
Demo: https://dev-dtu-c14d3ab4-dot-pinpoint-dot-chromeperf.appspot.com/
3 years, 3 months ago (2017-09-22 23:51:09 UTC) #2
shatch
lgtm
3 years, 3 months ago (2017-09-23 00:18:36 UTC) #3
perezju
lgtm
3 years, 2 months ago (2017-09-25 09:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3011403002/1
3 years, 2 months ago (2017-09-25 20:11:05 UTC) #6
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 20:43:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698