Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: telemetry/telemetry/page/cache_temperature_unittest.py

Issue 3011263002: Add cache_temperature state "HOT" (Closed)
Patch Set: check markers separately Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/cache_temperature_unittest.py
diff --git a/telemetry/telemetry/page/cache_temperature_unittest.py b/telemetry/telemetry/page/cache_temperature_unittest.py
index ae73bbd779b250f8bad3c08615e0cb4df9436d26..993ae334e338a7570b7b942046015d829cf994f1 100644
--- a/telemetry/telemetry/page/cache_temperature_unittest.py
+++ b/telemetry/telemetry/page/cache_temperature_unittest.py
@@ -50,7 +50,10 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):
markers = self.traceMarkers()
self.assertNotIn('telemetry.internal.ensure_diskcache.start', markers)
- self.assertNotIn('telemetry.internal.warm_cache.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.warm.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.warm.end', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.end', markers)
@decorators.Enabled('has tabs')
@decorators.Disabled('chromeos')
@@ -83,7 +86,10 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):
page, self._browser, previous_page)
markers = self.traceMarkers()
- self.assertNotIn('telemetry.internal.warm_cache.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.warm.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.warm.end', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.end', markers)
@decorators.Enabled('has tabs')
@decorators.Disabled('chromeos')
@@ -96,5 +102,72 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):
cache_temperature.EnsurePageCacheTemperature(page, self._browser)
markers = self.traceMarkers()
- self.assertIn('telemetry.internal.warm_cache.start', markers)
- self.assertIn('telemetry.internal.warm_cache.end', markers)
+ self.assertIn('telemetry.internal.warm_cache.warm.start', markers)
+ self.assertIn('telemetry.internal.warm_cache.warm.end', markers)
+
+ @decorators.Enabled('has tabs')
+ def testEnsureHotAfterColdAndWarmRun(self):
+ with self.captureTrace():
+ story_set = story.StorySet()
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.COLD, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(page, self._browser)
+
+ previous_page = page
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.WARM, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(
+ page, self._browser, previous_page)
+
+ previous_page = page
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.HOT, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(
+ page, self._browser, previous_page)
+
+ markers = self.traceMarkers()
+ self.assertNotIn('telemetry.internal.warm_cache.warm.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.warm.end', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.start', markers)
+ self.assertNotIn('telemetry.internal.warm_cache.hot.end', markers)
+
+ def testEnsureHotAfterColdRun(self):
+ with self.captureTrace():
+ story_set = story.StorySet()
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.COLD, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(page, self._browser)
+
+ previous_page = page
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.HOT, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(
+ page, self._browser, previous_page)
+
+ markers = self.traceMarkers()
+ # After navigation for another origin url, traces in previous origin page
+ # does not appear in |markers|, so we can not check this:
+ # self.assertIn('telemetry.internal.warm_cache.hot.start', markers)
+ # TODO: Ensure all traces are in |markers|
+ self.assertIn('telemetry.internal.warm_cache.hot.end', markers)
+
+ @decorators.Enabled('has tabs')
+ @decorators.Disabled('chromeos')
+ def testEnsureHotFromScratch(self):
+ with self.captureTrace():
+ story_set = story.StorySet()
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.HOT, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(page, self._browser)
+
+ markers = self.traceMarkers()
+ self.assertIn('telemetry.internal.warm_cache.warm.start', markers)
+ self.assertIn('telemetry.internal.warm_cache.warm.end', markers)
+ self.assertIn('telemetry.internal.warm_cache.hot.start', markers)
+ self.assertIn('telemetry.internal.warm_cache.hot.end', markers)

Powered by Google App Engine
This is Rietveld 408576698