Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 301113002: Fixed toV8 with empty context in InspectorFrontendClientImpl::windowObjectCleared (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
haraken, tkent, dgozman
CC:
blink-reviews
Visibility:
Public.

Description

Fixed toV8 with empty context in InspectorFrontendClientImpl::windowObjectCleared BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/InspectorFrontendClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-05-29 10:31:28 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-29 10:31:59 UTC) #2
dgozman
lgtm
6 years, 6 months ago (2014-05-29 11:05:29 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-05-30 03:46:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/301113002/1
6 years, 6 months ago (2014-05-30 03:48:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-30 09:45:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 12:38:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6516)
6 years, 6 months ago (2014-05-30 12:38:56 UTC) #8
tasak
+tkent Would you review Source/web code? I need Source/web OWNER's lgtm.
6 years, 6 months ago (2014-06-02 04:15:58 UTC) #9
tkent
rslgtm
6 years, 6 months ago (2014-06-02 04:16:47 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-02 04:16:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/301113002/1
6 years, 6 months ago (2014-06-02 04:17:07 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 04:32:54 UTC) #13
Message was sent while issue was closed.
Change committed as 175253

Powered by Google App Engine
This is Rietveld 408576698