Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 301103003: Rename navigator.serviceWorker.current to controller. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
falken, tkent, nhiroki
CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebaselines. #

Patch Set 3 : Bring rebaselines to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -128 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/serviceworker/controller-on-load.html View 2 chunks +7 lines, -7 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/serviceworker/controller-on-reload.html View 3 chunks +6 lines, -6 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/current-on-load.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/current-on-load-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/current-on-reload.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/current-on-reload-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-to-client.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/current-on-load-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/current-on-reload-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
dominicc (has gone to gerrit)
PTAL I'm making this part of the whenReady() bug because the spec describes whenReady in ...
6 years, 6 months ago (2014-05-29 05:02:07 UTC) #1
nhiroki
LGTM!
6 years, 6 months ago (2014-05-29 05:10:12 UTC) #2
falken
lgtm supernit: Rietveld breaks the URL in your CL description, maybe remove the brackets?
6 years, 6 months ago (2014-05-29 05:20:16 UTC) #3
dominicc (has gone to gerrit)
Brackets removed from URL. +tkent: Can I get OWNERS approval for public/platform?
6 years, 6 months ago (2014-05-30 00:48:06 UTC) #4
tkent
lgtm
6 years, 6 months ago (2014-05-30 01:07:31 UTC) #5
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-05-30 04:01:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/301103003/1
6 years, 6 months ago (2014-05-30 04:06:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-30 13:48:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 14:30:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10114)
6 years, 6 months ago (2014-05-30 14:30:55 UTC) #10
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-01 08:26:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/301103003/20001
6 years, 6 months ago (2014-06-01 08:27:03 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 08:27:14 UTC) #13
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-01 08:27:15 UTC) #14
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-01 22:42:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/301103003/40001
6 years, 6 months ago (2014-06-01 22:43:07 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-01 23:34:12 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 00:43:06 UTC) #18
Message was sent while issue was closed.
Change committed as 175237

Powered by Google App Engine
This is Rietveld 408576698