Report internal error when an exported library isn't loaded.

Report internal error when an exported library isn't loaded.

[ahe, 2017-09-04 08:30:45]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[Johnni Winther, 2017-09-04 10:36:52]

lgtm

[scheglov, 2017-09-04 18:31:14]

lgtm

https://codereview.chromium.org/3010963002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3010963002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:186:
DillLibraryBuilder library = loader.builders[libraryUri];
What if we have mutually exporting libraries?

[ahe, 2017-09-06 07:55:50]

Thank you, Johnni and Konstantin.

Konstantin, I think we need to discuss how to support external libraries in the
DillLoader and DillLibraryBuilder.

https://codereview.chromium.org/3010963002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3010963002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:186:
DillLibraryBuilder library = loader.builders[libraryUri];
On 2017/09/04 18:31:14, scheglov wrote:
> What if we have mutually exporting libraries?

If they're in the same dill file, it shouldn't be a problem. I can imagine some
issues if they are in two different dill files and have external references to
each other. That's a scenario that isn't implemented/supported yet.

In fact, I think there's a lot of stuff lacking wrt to external libraries in the
dill/ folder.