Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301093003: device/bluetooth: Update characteristic value D-Bus bindings. (Closed)

Created:
6 years, 6 months ago by armansito
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

device/bluetooth: Update characteristic value D-Bus bindings. The original BlueZ GATT API doc spec used DBus.Properties interface for characteristic value access. Since we are modifying this API for Chrome OS, this CL updates the Chrome D-Bus bindings and modifies the device/bluetooth GATT code to use the new bindings for characteristic value reads, writes, and updates. BUG=378182 TEST=Tested against my custom bluetoothd build; device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275693

Patch Set 1 #

Patch Set 2 : Fixed comments. #

Total comments: 5

Patch Set 3 : Use constants from cros_system_api. #

Patch Set 4 : Rebased #

Patch Set 5 : Removed unusued function for compile warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -198 lines) Patch
M chromeos/dbus/bluetooth_gatt_characteristic_client.h View 4 chunks +32 lines, -4 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_client.cc View 1 2 5 chunks +149 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_service_client.cc View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.cc View 1 2 3 8 chunks +62 lines, -67 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 5 chunks +20 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 1 2 3 7 chunks +46 lines, -52 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 2 chunks +8 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 1 2 3 4 3 chunks +10 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
armansito
6 years, 6 months ago (2014-05-29 03:29:22 UTC) #1
keybuk
https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc File chromeos/dbus/bluetooth_gatt_characteristic_client.cc (right): https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc#newcode22 chromeos/dbus/bluetooth_gatt_characteristic_client.cc:22: There doesn't seem to be any reason NOT to ...
6 years, 6 months ago (2014-05-30 22:22:39 UTC) #2
armansito
https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc File chromeos/dbus/bluetooth_gatt_characteristic_client.cc (right): https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc#newcode22 chromeos/dbus/bluetooth_gatt_characteristic_client.cc:22: On 2014/05/30 22:22:40, keybuk wrote: > There doesn't seem ...
6 years, 6 months ago (2014-05-30 22:37:20 UTC) #3
armansito
https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc File chromeos/dbus/bluetooth_gatt_characteristic_client.cc (right): https://codereview.chromium.org/301093003/diff/10001/chromeos/dbus/bluetooth_gatt_characteristic_client.cc#newcode22 chromeos/dbus/bluetooth_gatt_characteristic_client.cc:22: On 2014/05/30 22:22:40, keybuk wrote: > There doesn't seem ...
6 years, 6 months ago (2014-06-05 06:14:21 UTC) #4
keybuk
lgtm
6 years, 6 months ago (2014-06-06 17:56:05 UTC) #5
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 05:14:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/301093003/50001
6 years, 6 months ago (2014-06-07 05:15:50 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 08:44:19 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 09:07:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/21722)
6 years, 6 months ago (2014-06-07 09:07:46 UTC) #10
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 15:14:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/301093003/70001
6 years, 6 months ago (2014-06-07 15:14:45 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 20:26:55 UTC) #13
Message was sent while issue was closed. 
Change committed as 275693

Powered by Google App Engine
This is Rietveld 408576698