Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1907)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 3010873002: fix missing SDK symbols (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index e2552798ef4753d54ddc48977344feef0937fdb1..a1b4433119fa4f3449b0f85a17120654ee2bbe4a 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -1986,11 +1986,10 @@ class CodeGenerator extends Object
/// Ensure `dartx.` symbols we will use are present.
void _initExtensionSymbols(ClassElement classElem,
List<MethodDeclaration> methods, List<FieldDeclaration> fields) {
- if (_extensionTypes.hasNativeSubtype(classElem.type)) {
+ if (_extensionTypes.hasNativeSubtype(classElem.type) ||
+ classElem.type.isObject) {
for (var m in methods) {
- if (!m.isAbstract &&
- !m.isStatic &&
- resolutionMap.elementDeclaredByMethodDeclaration(m).isPublic) {
+ if (!m.isAbstract && !m.isStatic && m.element.isPublic) {
_declareMemberName(m.element, useExtension: true);
}
}
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698