Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 3010873002: fix missing SDK symbols (Closed)

Created:
3 years, 3 months ago by Jennifer Messerly
Modified:
3 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix missing SDK symbols in particular, this fixes the bug that `dartx.noSuchMethod` resulted in undefined R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/7d142f603370ad7e959197dd6e9a73e291606c5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
3 years, 3 months ago (2017-09-01 03:19:44 UTC) #3
Leaf
LGTM So was something defining [dartx.noSuchmethod] to be a noSuchMethod function. and hence ending up ...
3 years, 3 months ago (2017-09-01 05:05:03 UTC) #4
Jennifer Messerly
On 2017/09/01 05:05:03, Leaf wrote: > LGTM > > So was something defining [dartx.noSuchmethod] to ...
3 years, 3 months ago (2017-09-01 20:12:53 UTC) #5
Jennifer Messerly
3 years, 3 months ago (2017-09-01 20:13:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d142f603370ad7e959197dd6e9a73e291606c5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698