Issue 3010833002: Add the new @notForDart2 annotation and mark several tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3010833002: Add the new @notForDart2 annotation and mark several tests. (Closed)

Created:
3 years, 3 months ago by scheglov

Modified:
3 years, 3 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add the new @notForDart2 annotation and mark several tests. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9cee3776ac2b410e806ef394534eba80384159da

Patch Set 1 #

Total comments: 1

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View		3 chunks	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm, assuming you're sure they won't be supported https://codereview.chromium.org/3010833002/diff/1/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart File pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart (right): https://codereview.chromium.org/3010833002/diff/1/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart#newcode319 pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart:319: @notForDart2 ...

3 years, 3 months ago (2017-08-31 20:10:10 UTC) #2

scheglov

3 years, 3 months ago (2017-08-31 21:13:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9cee3776ac2b410e806ef394534eba80384159da (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages